EMIN AKTURK | BIRMINGHAM | MODULE-DATA-GROUPS - SPRINT 1 #754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eminakturk
added
the
Needs Review
LonMcGregor
added
Review in progress
LonMcGregor
reviewed
Aug 11, 2025
| } | ||
|
|
||
| const seen = new Set(); | ||
| return elements.filter(element => { |
There was a problem hiding this comment.
While using a filter here does work, I feel like it is perhaps not the most logical way to approach this task.
Filters are typically used to transform one array into another, here you are using it to make changes to a set. Can you think of a way to rewrite this that might make it more readable / clear what the code is intended to do?
LonMcGregor
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.